[PATCH 02/29] wimax: headers for kernel API and user space interaction

[Johannes Berg]

On Mon, 2008-12-08 at 11:09 -0800, Inaky Perez-Gonzalez wrote:

> +/*
> + * Generic NetLink operations
> + *
> + * Most of these map to an API call; _OP_ stands for operation, _RP_
> + * for reply and _RE_ for report (aka: signal).
> + */
> +enum {
> +	WIMAX_GNL_OP_MSG_FROM_USER,	/* User to kernel message */
> +	WIMAX_GNL_OP_MSG_TO_USER,	/* Kernel to user message */

Since you're going to do these iwpriv-style things anyway no matter what
I say :) can we at least get it to use netlink attributes *within*
these? In i2400m you define a new protocol that pretty much looks
identical to netlink attributes, but just a bit different:

> + * This is the control protocol used by the host to control the i2400m
> + * device (scan, connect, disconnect...). This is sent to / received
> + * as control frames. These frames consist of a header and zero or
> + * more TLVs with information. We call each control frame a "message".

Or isn't that what is contained in the WIMAX_GNL_MSG_DATA attribute? You
can nest netlink attributes, that would already make it a whole lot more
regular, rather than defining your own sub-protocol.

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
Url : http://lists.moblin.org/pipermail/wimax/attachments/20081208/66ea1bae/attachment.bin